Fix README token rotation procedure ordering#26
Merged
Conversation
The previous rotation steps caused a full secret-lookup outage on a real deployment: restarting psi-secrets.service first turned on auth enforcement while every existing Podman secret still had the old curl command (no Authorization header) baked into Spec.Driver.Options, so every lookup failed with 401 and dependent services cascade-failed. The correct order: 1. Update the config/credential 2. Regenerate containers.conf.d/psi.conf (psi install or --stdout pipe) 3. Restart podman.service so the API picks up the new conf 4. Re-run psi setup to re-register every workload secret with the new driver opts 5. Manually re-register HSM-backed and podman-only secrets (psi setup only touches config.workloads) 6. Restart psi-secrets.service LAST so auth enforcement flips on after every secret has been refreshed Document the ordering requirement explicitly and the reason (Podman caches containers.conf at startup and secret driver opts are baked in at create time).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rewrite the "Token rotation" section of the README. The previous procedure caused a full secret-lookup outage on a real deployment: restarting `psi-secrets.service` first turned on auth enforcement while every existing Podman secret still had the old curl command (no `Authorization` header) baked into `Spec.Driver.Options`, so every lookup failed with 401 until the final step.
Two facts make ordering load-bearing:
The correct order:
A follow-up will add a `psi rotate-token` command that orchestrates this as a single operation.
Test plan